theme-node: Fix font family formatting

Unlike pango_font_description_from_string(),
pango_font_description_set_family() requires a already properly
formatted font family string. The proper format is a comma seperated
list of font families, but we generated a "comma space" separated list.
Passing a incorrectly formatted font family string to pango seems to
cause wierd issues, where the wrong font is sometimes selected.

For example, this fixes a font selection issue on zh_TW.UTF-8 locale for
chinese characters, where previously the "Droid Sans" font was selected
instead of "Source Han Sans TW" even though fontconfig had placed
"Source Han Sans TW" before "Droid Sans".

https://bugzilla.gnome.org/show_bug.cgi?id=786868

diff --git a/src/st/st-theme-node.c b/src/st/st-theme-node.c
index 877cf1da1739e75ec4cf06094e8d7dd6ff2dac08..3739b93b4b42e020226aea114d7787dbeb7616af 100644 (file)
--- a/src/st/st-theme-node.c
+++ b/src/st/st-theme-node.c
@@ -2576,7 +2576,7 @@ font_family_from_terms (CRTerm *term,
           if (term->the_operator == NO_OP)
             g_string_append (family_string, " ");
           else
-            g_string_append (family_string, ", ");
+            g_string_append (family_string, ",");
         }
       else
         {